-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Deprecate rk3588-legacy
in favor of rk3588-vendor
#6835
Comments
Jira ticket: AR-2394 |
rk3588-legacy
in favor of rk3588-vendor
rk3588-legacy
in favor of rk3588-vendor
I've one use case for the legacy / 5.10 kernel: being able to write MAC addresses to the Realtek 2.5gbit (r8125/r8169) ethernets. See instructions at Mario's -- the program only builds and works on 5.10, not 6.1. Otherwise, I use legacy on "production" systems -- if it is removed from Armbian, I'll be forced to userpatch the hell out of it. |
We can remove it from board configs - "legacy" is anyway EOL label. And later remove source defs. |
Yes. I'd be happy if it's removed from KERNEL_TARGETS, since we can actually build BRANCH=legacy even if it isn't listed there. But I'd keep the family code handling it, which amounts to a 10-line block (repeated twice, just like |
Okay we can do it like that if you prefer 👍 I have updated the task list to reflect this approach. Feel free to edit it :) |
With a soon-to-be-updated linux-rockchip
6.1-rkr3
kernel, it may be time to finally sunset the 5.10legacy
kernel for RK3588.The 6.1
vendor
kernel is overall just a better/more up-to-date version of the Rockchip kernel and will receive updates down the line. With the recent addition of thecurrent
kernel branch for RK3588, we currently have 5 active kernel branches for this SOC: https://github.com/armbian/build/blob/main/config/sources/families/rockchip-rk3588.confIt's also easier for @amazingfate to maintain only one branch of the kernel.
This task/issue is a place to discuss this topic before implementation. Let's hear your opinions 😄
Task List
For marking the
legacy
kernel as deprecated/EOL (now):legacy
kernel target from board configs #6881KERNELPATCHDIR
to default forvendor
in the family configFor removing the
legacy
kernel as a whole (TO-DO at a later date):legacy
andvendor
point to the same variables in the family configrk3588-legacy
legacy
rk3588 kernel in the codeThe text was updated successfully, but these errors were encountered: