Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for package name resolution in type name resolution #119

Open
mjmdavis opened this issue Nov 20, 2018 · 0 comments
Open

No support for package name resolution in type name resolution #119

mjmdavis opened this issue Nov 20, 2018 · 0 comments

Comments

@mjmdavis
Copy link

mjmdavis commented Nov 20, 2018

Pyrobuf does not support package resolution when resolving type names.

When processing a line like:

optional package.enumtype fieldname = 4;

the parser returns:

Exception: Unexpected character '.' on line 35: '    optional package.enumtype fieldname = 4;'

This looks like it could be an easyish fix.

First step would be adding a . to the regex here https://github.com/appnexus/pyrobuf/blob/master/pyrobuf/parse_proto.py#L23

Then would need to work out how to resolve the packages based on the field type strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant