Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Button Icon + Text has uncentered padding #946

Open
rsadres opened this issue Aug 7, 2018 · 3 comments
Open

Basic Button Icon + Text has uncentered padding #946

rsadres opened this issue Aug 7, 2018 · 3 comments
Assignees

Comments

@rsadres
Copy link
Contributor

rsadres commented Aug 7, 2018

Buttons have standard padding, Icons have standard padding, it's looking like when we bundle all of that together, the icon + text buttons are lopsided, they have more space on the left side than on the right side. Is there something we can do to make the icon + text buttons even, without affecting the other buttons or other places where the checkIcon is used?
screenshot 2018-08-07 09 57 14

I feel like this came up before and we resolved it before...

@rsadres
Copy link
Contributor Author

rsadres commented Aug 14, 2018

@liliedelamotte , let's look at Joe's selector fix - https://codepen.io/jhsu/pen/PBgqqe?editors=0010

@rsadres
Copy link
Contributor Author

rsadres commented Aug 15, 2018

Per @jondlm suggestion, let's create a new icon/text button component.

These icons are frequently used in icon/text buttons. Let's make sure we optimize styling to accommodate these.
PlusIcon
EditPageIcon
EditIcon
ViewIcon
DownloadIcon
DuplicateIcon
UploadIcon

We occasionally use these icons in icon/text buttons, can we see if any of these break just to be aware.
ArrowIcon
DeleteIcon
SwitchIcon
UserIcon

@rsadres
Copy link
Contributor Author

rsadres commented Aug 15, 2018

Not necessarily related, but these icons are frequently used in in Icon only buttons, maybe we should check on these while we're here :)

TableGearIcon
RefreshIcon
EditIcon
AnalyzeDataIcon
DataViewIcon
EditPageIcon
DeleteIcon
DuplicateIcon
SettingsIcon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants