Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Integration Issues Caused by Aging apollo-client Dependency #204

Closed
2 of 5 tasks
Phylodome opened this issue Aug 2, 2019 · 3 comments
Closed
2 of 5 tasks

Integration Issues Caused by Aging apollo-client Dependency #204

Phylodome opened this issue Aug 2, 2019 · 3 comments

Comments

@Phylodome
Copy link

Currently running into dependency issues (basically this) when attempting to use a package (reason-apollo-hooks) that adds hooks functionality to reason-apollo.

Is there a timeline for either the formal inclusion of hooks functionality within this package (conversation seems to have stalled here), or at the very least for the package to be brought up to date with respect to other deps that would unblock the community to continue developing apace changes to apollo-client and react-apollo?

As mentioned in #202, it's likely this upgrade is non-trivial. But it would be useful to know whether it's in the works, or if a PR would be welcome if someone were to put in the required effort.

Issue Labels

  • has-reproduction
  • feature
  • docs
  • blocking
  • good first issue
@Yakimych
Copy link

Yakimych commented Aug 3, 2019

@MargaretKrutikova has a PR with those updates in her fork: https://github.com/MargaretKrutikova/reason-apollo/pull/1/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

It does resolve the getCurrentResult crash - would be great if this could get reviewed and eventually merged into the main repo if possible.

@Gregoirevda
Copy link
Contributor

@Phylodome thanks for raising up this issue. [email protected] has the upgraded dependencies

@Phylodome
Copy link
Author

Wonderful. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants