Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support concurrent loading of Config for different namespaces (#29) #31

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

zth9
Copy link
Contributor

@zth9 zth9 commented Aug 1, 2023

What's the purpose of this PR

fix #29

Which issue(s) this PR fixes:

Fixes #29

Brief changelog

  • Support concurrent loading of Config for different namespaces.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #31 (bff4bcf) into main (265fe49) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #31      +/-   ##
============================================
- Coverage     68.32%   68.25%   -0.08%     
+ Complexity     1191     1190       -1     
============================================
  Files           169      169              
  Lines          5156     5160       +4     
  Branches        561      561              
============================================
- Hits           3523     3522       -1     
- Misses         1369     1371       +2     
- Partials        264      267       +3     
Files Changed Coverage Δ
...amework/apollo/internals/DefaultConfigManager.java 93.33% <100.00%> (+1.02%) ⬆️

... and 3 files with indirect coverage changes

@zth9
Copy link
Contributor Author

zth9 commented Aug 2, 2023

I have read the CLA Document and I hereby sign the CLA

@nobodyiam
Copy link
Member

I think the changes are looking great! Could you also please make sure to update the CHANGES.md?

@zth9
Copy link
Contributor Author

zth9 commented Aug 12, 2023

I think the changes are looking great! Could you also please make sure to update the CHANGES.md?

All tasks have been completed.🤝

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit e4d12c7 into apolloconfig:main Aug 13, 2023
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2023
@nobodyiam nobodyiam added this to the 2.2.0 milestone Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultConfigManager获取Config加锁,导致无法并发初始化多个不同namespace的Config
2 participants