Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality to allow ArrayBuffer inputs along with file path #35

Closed
AdityaSarwade opened this issue Aug 2, 2023 · 1 comment · Fixed by #36
Closed

Functionality to allow ArrayBuffer inputs along with file path #35

AdityaSarwade opened this issue Aug 2, 2023 · 1 comment · Fixed by #36

Comments

@AdityaSarwade
Copy link
Contributor

Hey, @j6k4m8 I've used your package in a few packages and I think it is a life-saver.

I faced an issue when I wanted to parse and open a .npy file from and ArrayBuffer in TypeScript.
I identified that the load function internally creates an ArrayBuffer which stores the result of the fetch request.

It would be really helpful if we could bypass this part of the code when the passed argument is already an ArrayBuffer.

Although I am not as experienced as my peers, I'm submitting a PL as it might be a useful addition.

@AdityaSarwade AdityaSarwade changed the title Functionality to alloww ArrayBuffer inputs along with file path Functionality to allow ArrayBuffer inputs along with file path Aug 2, 2023
@j6k4m8
Copy link
Member

j6k4m8 commented Aug 3, 2023

Yes, love it!! thank you for #36!!

@j6k4m8 j6k4m8 linked a pull request Aug 3, 2023 that will close this issue
@j6k4m8 j6k4m8 closed this as completed in #36 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants