Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adapt cluster describe command with 1.0 api #438

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Sep 4, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.29508% with 176 lines in your changes missing coverage. Please review.

Project coverage is 43.37%. Comparing base (55f8f45) to head (1bf34ab).

Files with missing lines Patch % Lines
pkg/cluster/component.go 0.00% 63 Missing ⚠️
pkg/cmd/cluster/connect.go 49.33% 29 Missing and 9 partials ⚠️
pkg/cluster/cluster.go 66.66% 23 Missing and 11 partials ⚠️
pkg/cluster/helper.go 17.94% 29 Missing and 3 partials ⚠️
pkg/cmd/cluster/describe.go 62.50% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   43.39%   43.37%   -0.03%     
==========================================
  Files         174      175       +1     
  Lines       24500    24626     +126     
==========================================
+ Hits        10632    10681      +49     
- Misses      12637    12697      +60     
- Partials     1231     1248      +17     
Flag Coverage Δ
unittests 43.37% <42.29%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit 6ba8b9b into main Sep 5, 2024
14 checks passed
@wangyelei wangyelei deleted the feature/adapt_describe_cmd branch September 5, 2024 01:13
@github-actions github-actions bot added this to the Release 0.9.1 milestone Sep 5, 2024
@wangyelei
Copy link
Contributor Author

fix #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants