Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update new monitor api for kbcli (#7015) #316

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

sophon-zt
Copy link
Contributor

@sophon-zt sophon-zt commented Apr 12, 2024

  1. update kubeblocks version to 0.9.0-beta.12
  2. deleted const variables migrated from kubeblocks to kbcli.
  3. adapt to the new monitor api.

@sophon-zt sophon-zt linked an issue Apr 12, 2024 that may be closed by this pull request
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Apr 12, 2024
@sophon-zt sophon-zt force-pushed the feature/refactor-monitor-related-api-issue7015 branch from 67d782e to 16f387f Compare April 23, 2024 10:15
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Apr 23, 2024
@sophon-zt sophon-zt marked this pull request as ready for review April 23, 2024 10:19
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 43.03797% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 42.86%. Comparing base (ffdfa90) to head (16f387f).

❗ Current head 16f387f differs from pull request most recent head b27dbda. Consider uploading reports for the commit b27dbda to get more accurate results

Files Patch % Lines
pkg/cmd/cluster/update.go 38.77% 24 Missing and 6 partials ⚠️
pkg/cluster/helper.go 14.28% 6 Missing ⚠️
pkg/cmd/cluster/create.go 70.00% 2 Missing and 1 partial ⚠️
pkg/cmd/builder/template/component_wrapper.go 0.00% 2 Missing ⚠️
pkg/cmd/kubeblocks/status.go 0.00% 2 Missing ⚠️
pkg/cmd/clusterversion/clusterversion.go 50.00% 0 Missing and 1 partial ⚠️
pkg/cmd/plugin/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   42.89%   42.86%   -0.04%     
==========================================
  Files         213      213              
  Lines       28949    28994      +45     
==========================================
+ Hits        12419    12427       +8     
- Misses      15002    15033      +31     
- Partials     1528     1534       +6     
Flag Coverage Δ
unittests 42.86% <43.03%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming merged commit 7f7a69e into main Apr 26, 2024
8 checks passed
@ldming ldming deleted the feature/refactor-monitor-related-api-issue7015 branch April 26, 2024 09:23
@github-actions github-actions bot added this to the Release 0.9.0 milestone Apr 26, 2024
@sophon-zt
Copy link
Contributor Author

/cherry-pick release-0.9

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8848022692

github-actions bot pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-interaction size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Features] refactor monitor-related api
4 participants