-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable kbcli addons in batch #313
feat: disable kbcli addons in batch #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not commit changes of submodules.
Hi @SuperAayush , nice to receive your PR! |
Hey @1aal, I agree with your suggestions I had a chat regarding the same with @shanshanying over a call. kbcli/pkg/cmd/addon/addon_test.go Line 114 in 7dc2556
Also after validating the test, the process is stuck here: Line 332 in 7dc2556
I have even tried to fetch the selector labels and they match exactly but the process is still stuck. cc - @shanshanying Thanks!! |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment |
@SuperAayush this pr has been refined and merged to main branch a97d12d |
The PR contains the code to make the kbcli to disable more than one addon at once.
Fixes: #237