Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alert config #220

Merged
merged 5 commits into from
Jan 11, 2024
Merged

feat: alert config #220

merged 5 commits into from
Jan 11, 2024

Conversation

lynnleelhl
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Jan 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (46024cf) 42.70% compared to head (c387afe) 42.70%.
Report is 10 commits behind head on main.

Files Patch % Lines
pkg/cmd/alert/add_receiver.go 27.77% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   42.70%   42.70%           
=======================================
  Files         230      230           
  Lines       29633    29643   +10     
=======================================
+ Hits        12654    12660    +6     
- Misses      15422    15426    +4     
  Partials     1557     1557           
Flag Coverage Δ
unittests 42.70% <45.83%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnleelhl lynnleelhl merged commit 12f94b6 into main Jan 11, 2024
12 checks passed
@lynnleelhl lynnleelhl deleted the feature/alert-config branch January 11, 2024 04:00
@github-actions github-actions bot added this to the Release 0.8.0 milestone Jan 11, 2024
@lynnleelhl
Copy link
Contributor Author

/cherry-pick release-0.8

Copy link

🤖 says: Error cherry-picking.

Auto-merging pkg/cmd/alert/add_receiver.go
CONFLICT (content): Merge conflict in pkg/cmd/alert/add_receiver.go
Auto-merging pkg/cmd/alert/add_receiver_test.go
CONFLICT (content): Merge conflict in pkg/cmd/alert/add_receiver_test.go
Auto-merging pkg/cmd/alert/config_smtpserver.go
Auto-merging pkg/cmd/alert/delete_receiver.go
Auto-merging pkg/cmd/alert/list_receivers.go
Auto-merging pkg/cmd/alert/list_smtpserver.go
error: could not apply 12f94b6... feat: alert config (#220)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kbcli/actions/runs/7484066488

lynnleelhl added a commit that referenced this pull request Jan 11, 2024
(cherry picked from commit 12f94b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants