Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all addons when uninstall KubeBlocks #193

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

ldming
Copy link
Collaborator

@ldming ldming commented Jan 5, 2024

Remove all addons when uninstall KubeBlocks.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Jan 5, 2024
@ldming ldming changed the title chore: remove all addon when uninstall KubeBlocks chore: remove all addons when uninstall KubeBlocks Jan 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (4f8c94a) 42.69% compared to head (6a0caf3) 42.70%.

Files Patch % Lines
pkg/cmd/kubeblocks/uninstall.go 5.55% 17 Missing ⚠️
pkg/cmd/kubeblocks/install.go 23.80% 16 Missing ⚠️
pkg/cmd/kubeblocks/util.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   42.69%   42.70%           
=======================================
  Files         230      230           
  Lines       29594    29605   +11     
=======================================
+ Hits        12635    12642    +7     
- Misses      15402    15406    +4     
  Partials     1557     1557           
Flag Coverage Δ
unittests 42.70% <21.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming merged commit 910715c into main Jan 5, 2024
20 checks passed
@ldming ldming deleted the support/delete-all-addons-when-uninstall-kb branch January 5, 2024 06:59
@github-actions github-actions bot added this to the Release 0.8.0 milestone Jan 5, 2024
ldming added a commit that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants