diff --git a/src/replica/duplication/mutation_batch.cpp b/src/replica/duplication/mutation_batch.cpp index e306a936de..8e84e19d58 100644 --- a/src/replica/duplication/mutation_batch.cpp +++ b/src/replica/duplication/mutation_batch.cpp @@ -173,7 +173,8 @@ void mutation_batch::add_mutation_if_valid(mutation_ptr &mu, decree start_decree // ERR_OPERATION_DISABLED, but there could still be a mutation written // before the duplication was added. // To ignore means this write will be lost, which is acceptable under this rare case. - if (!task_spec::get(update.code)->rpc_request_is_write_idempotent && !FLAGS_force_send_no_idempotent_when_duplication) { + if (!task_spec::get(update.code)->rpc_request_is_write_idempotent && + !FLAGS_force_send_no_idempotent_when_duplication) { continue; } blob bb; diff --git a/src/replica/replica_2pc.cpp b/src/replica/replica_2pc.cpp index a43c556707..c3235b9438 100644 --- a/src/replica/replica_2pc.cpp +++ b/src/replica/replica_2pc.cpp @@ -93,7 +93,6 @@ DSN_DEFINE_bool("replication", "doing duplication"); DSN_TAG_VARIABLE(force_send_no_idempotent_when_duplication, FT_MUTABLE); - DSN_DEFINE_int32(replication, prepare_timeout_ms_for_secondaries, 1000, diff --git a/src/server/pegasus_write_service.cpp b/src/server/pegasus_write_service.cpp index 98bd0320d1..50f7add25c 100644 --- a/src/server/pegasus_write_service.cpp +++ b/src/server/pegasus_write_service.cpp @@ -456,7 +456,6 @@ int pegasus_write_service::duplicate(int64_t decree, } } - resp.__set_error(rocksdb::Status::kInvalidArgument); resp.__set_error_hint(fmt::format("unrecognized task code {}", request.task_code)); return empty_put(ctx.decree);