[WIP] Add support for external tables with qualified names #12645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OussamaSaoudi
commented
Sep 27, 2024
| visitor | ||
| .relations | ||
| .insert(ObjectName(vec![Ident::from(table.name.as_str())])); | ||
| let idents: Vec<Ident> = table.name.split('.').map(Ident::from).collect(); |
There was a problem hiding this comment.
This part is not necessary for the bug fix. Not sure if I should leave it here to maintain consistency of external table name handling.
|
@alamb I've never written tests for Datafusion before. What's a good spot to test this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12607
Rationale for this change
What changes are included in this PR?
This PR adds the ability to create external tables with qualified names.
Are these changes tested?
Not yet, tests incoming!
Are there any user-facing changes?
Yes there are user-facing changes. Previously, external tables with qualified names was unsupported.