Fix sort node deserialization from proto #12626
Merged
+46
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
andygrove
reviewed
Sep 25, 2024
| LogicalPlanBuilder::from(input).sort(sort_expr)?.build() | ||
| let fetch: usize = sort.fetch.try_into().map_err(|_| { | ||
| DataFusionError::Internal(String::from( | ||
| "Protobuf deserialization error, invalid limit value'", |
There was a problem hiding this comment.
It would be good to show the invalid value and/or the error message to ease debugging
|
Also, could you add/update a unit test so that we prevent future regressions? |
alamb
reviewed
Sep 26, 2024
| @@ -341,6 +341,32 @@ async fn roundtrip_logical_plan_aggregation() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn roundtrip_logical_plan_sort() -> Result<()> { | |||
|
I took the liberty of fixing the |
|
I guess when no |
andygrove
reviewed
Sep 26, 2024
| @@ -704,6 +730,7 @@ async fn roundtrip_logical_plan_distinct_on() -> Result<()> { | |||
| let plan = ctx.sql(query).await?.into_optimized_plan()?; | |||
|
|
|||
| let bytes = logical_plan_to_bytes(&plan)?; | |||
| println!("plan {:?}", plan); | |||
There was a problem hiding this comment.
nit: could you remove this debug println?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?