Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement nested identifier access #12614

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Lordworms
Copy link
Contributor

@Lordworms Lordworms commented Sep 25, 2024

Which issue does this PR close?

Closes #11445

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@Lordworms
Copy link
Contributor Author

I didn't realize that there is already a function called get_field which has similar usage to struct_extract 😅

@github-actions github-actions bot added sql SQL Planner sqllogictest SQL Logic Tests (.slt) labels Sep 26, 2024
@Lordworms Lordworms marked this pull request as ready for review September 26, 2024 07:52
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Lordworms -- this is really nice 😍

Really nice way to reuse get_field

datafusion/sql/src/expr/identifier.rs Outdated Show resolved Hide resolved
datafusion/sql/src/expr/identifier.rs Outdated Show resolved Hide resolved
} AS complex_data;

query T
SELECT complex_data.user.info.personal.name FROM complex_view;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions sql SQL Planner sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement nested identifier access ( "Nested identifiers not yet supported" )
2 participants