support Decimal256 type in datafusion-proto #11606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
force-pushed
the
datafusion-proto-decimal-256
branch
from
7724655
to
327f045
Compare
andygrove
approved these changes
Jul 22, 2024
|
Thanks @leoyvens and @andygrove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11607.
Rationale for this change
Fixes a simple omission.
What changes are included in this PR?
Added support for the Decimal256 type in datafusion-proto.
Are these changes tested?
There is a unit test. Manual testing of the affected use case was also successful.
Are there any user-facing changes?
This bug was reproducible by users.