-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: get file size by func metadata #11575
Conversation
20 | ||
}; | ||
|
||
let file_size = std::fs::metadata("tests/data/one_col.csv")?.len() as usize; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how this test is passing on CI? In theory we run these tests on CI:
https://github.com/apache/datafusion/actions/runs/10044145872/job/27758535504
but somehow this test does not appear to run 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zhuliquan -- this makes sense to me.
I don't understand how this issue isn't caught on the CI runner though
I also got confused, datafusion/.github/workflows/rust.yml Lines 323 to 338 in 77311a5
|
Or maybe it runs in WSL or something |
Anyhow, thanks again @zhuliquan |
Which issue does this PR close?
Closes #11574.
Rationale for this change
fix failure running of case test_csv_parallel_one_col on windows machine
What changes are included in this PR?
getting
file_size
according to funcmetadata
instead oftarget_os
Are these changes tested?
yes
Are there any user-facing changes?
no