Minor: move Column related tests and rename column.rs
#11573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jul 22, 2024
| @@ -100,49 +100,3 @@ impl PartialEq<dyn Any> for UnKnownColumn { | |||
| false | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It seems like datafusion/physical-expr/src/expressions/column.rs could also be renamed to datafusion/physical-expr/src/expressions/unknown_column.rs or datafusion/physical-expr/src/expressions/unknown.rs to better match its contents
There was a problem hiding this comment.
Renamed it to unknown_column.rs in f4407ac
jonahgao
changed the title
Column related testsColumn related tests and rename column.rs
|
🚀 |
Lordworms
pushed a commit
to Lordworms/arrow-datafusion
that referenced
this pull request
Jul 23, 2024
* Minor: move `Column` related tests * Rename column.rs to unknown_column.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
These tests belong to
Column. It would be better to put them together.What changes are included in this PR?
Move tests
Are these changes tested?
Yes
Are there any user-facing changes?
No