Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move
sql_compound_identifier_to_expr
toExprPlanner
#11487Move
sql_compound_identifier_to_expr
toExprPlanner
#11487Changes from 6 commits
ba92a84
44118b9
404347e
1adc9a4
5f4ac70
38debfc
6623219
040dc3c
73cf5fa
e4a7d7c
7c52b3d
2ab18e4
9378d15
1379cd7
d6c3590
d2fa19a
3076d54
091260f
40ab63c
671ee93
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder could we plan the whole compound identifier, the benefit of
plan_*
function is able to customize the operator (in this case is compound identifier i.e.a.b.c
) and expressions we get.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally i wanted to do that same, but this function uses
IdentNormalizer
field ofSqlToRel
struct. I am just thinking a way around & wanted to discuss the same here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the result of
self.normalizer.normalize()
as the planner arguments, similar to the spirit of others function that we take the result ofsql_expr_to_logical_expr
as the planner argumentsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this revision ? Do you think we aligned here ? There is still more work to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fn sql_compound_identifier_to_expr
does many things, handles the logic for variable, compund indentifier & compund indentifier in outer query. In this change we are only supporting compund indentifier & not adding support compund indentifier in outer query.