From 7ae54c82258617b8d20b5a09a1c1571c8ee1a8d1 Mon Sep 17 00:00:00 2001 From: Brent Gardner Date: Wed, 13 Sep 2023 08:43:03 -0600 Subject: [PATCH] PR feedback --- .../core/src/physical_plan/aggregates/topk/hash_table.rs | 1 - datafusion/core/src/physical_plan/aggregates/topk/heap.rs | 7 ------- 2 files changed, 8 deletions(-) diff --git a/datafusion/core/src/physical_plan/aggregates/topk/hash_table.rs b/datafusion/core/src/physical_plan/aggregates/topk/hash_table.rs index 889382fcb353..f0be672d7c12 100644 --- a/datafusion/core/src/physical_plan/aggregates/topk/hash_table.rs +++ b/datafusion/core/src/physical_plan/aggregates/topk/hash_table.rs @@ -335,7 +335,6 @@ impl HashTableItem { } } -#[allow(dead_code)] #[cfg(test)] fn map_print(map: &RawTable>) { use itertools::Itertools; diff --git a/datafusion/core/src/physical_plan/aggregates/topk/heap.rs b/datafusion/core/src/physical_plan/aggregates/topk/heap.rs index 5719947aed6a..b8dde05cd430 100644 --- a/datafusion/core/src/physical_plan/aggregates/topk/heap.rs +++ b/datafusion/core/src/physical_plan/aggregates/topk/heap.rs @@ -179,12 +179,6 @@ impl TopKHeap { self.heap[0].as_ref().map(|hi| hi.map_idx).unwrap_or(0) } - #[allow(dead_code)] - pub fn len(&self) -> usize { - self.len - } - - #[allow(dead_code)] pub fn is_full(&self) -> bool { self.len >= self.capacity } @@ -334,7 +328,6 @@ impl TopKHeap { valid } - #[allow(dead_code)] #[cfg(test)] pub fn tree_print(&self) -> String { let mut builder = ptree::TreeBuilder::new("BinaryHeap".to_string());