Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modulus can produce incorrect results in some cases #521

Open
andygrove opened this issue Jun 5, 2024 · 3 comments · May be fixed by #585
Open

Modulus can produce incorrect results in some cases #521

andygrove opened this issue Jun 5, 2024 · 3 comments · May be fixed by #585
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

Describe the bug

Example of compatibility issue found by fuzz testing:

SELECT c90, c1, c90 % c1 FROM test1 ORDER BY c90, c1;

Spark: -21840,-0.0,NULL
Comet: -21840,-0.0,NaN

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
@andygrove andygrove added the bug Something isn't working label Jun 5, 2024
@vaibhawvipul
Copy link
Contributor

working on it.

@vaibhawvipul vaibhawvipul linked a pull request Jun 18, 2024 that will close this issue
Open
@vaibhawvipul
Copy link
Contributor

issue filed - apache/datafusion#11051

@vaibhawvipul
Copy link
Contributor

another one - apache/datafusion#11108

@andygrove andygrove added this to the 0.2.0 milestone Jul 25, 2024
@andygrove andygrove removed this from the 0.2.0 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: modulo op with negative zero divisor produces Nan vaibhawvipul/datafusion-comet
2 participants
@andygrove @vaibhawvipul