Fix encoding/decoding REE Dicts when using streaming IPC #6399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
alamb
reviewed
Sep 16, 2024
arrow-ipc/src/reader/stream.rs
Outdated
|
|
||
| let mut decoder = StreamDecoder::new(); | ||
| let buf = &mut Buffer::from(buffer.as_slice()); | ||
| while let Some(_) = decoder |
There was a problem hiding this comment.
I think we should update the test to verify the Batch that comes back in matches the batch that was written -- aka that the data round trips
| @@ -375,6 +375,7 @@ impl Field { | |||
| | DataType::FixedSizeList(field, _) | |||
| | DataType::Map(field, _) => field.fields(), | |||
| DataType::Dictionary(_, value_field) => Field::_fields(value_field.as_ref()), | |||
| DataType::RunEndEncoded(_, field) => field.fields(), | |||
brancz
force-pushed
the
ree-dict-ipc-fix
branch
from
ea3b6b0
to
0962732
Compare
brancz
force-pushed
the
ree-dict-ipc-fix
branch
from
0962732
to
df2a11f
Compare
|
Sorry for forgetting to |
|
I am depressed about the large review backlog in this crate. We are looking for more help from the community reviewing PRs -- see #6418 for more |
alamb
approved these changes
Sep 18, 2024
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6398
What changes are included in this PR?
Include dictionaries within REE dicts when recursively flattening all fields of a schema.
Are there any user-facing changes?
No, just a bug fix.
@alamb @tustvold