Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayData.align_buffers should support Struct data type / child data #6461

Open
EnricoMi opened this issue Sep 26, 2024 · 0 comments · May be fixed by #6462
Open

ArrayData.align_buffers should support Struct data type / child data #6461

EnricoMi opened this issue Sep 26, 2024 · 0 comments · May be fixed by #6462
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@EnricoMi
Copy link

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Method ArrayData.align_buffers ensures that data in the array buffers are aligned. This is needed if data come from IPC or FFI. In case of DataType::Struct, mis-aligned buffers are currently not aligned by this method, because it only aligns self.buffers, not buffers of self.child_data.

Describe the solution you'd like
Make ArrayData.align_buffers align buffers of child data recursively.
@EnricoMi EnricoMi added the enhancement Any new improvement worthy of a entry in the changelog label Sep 26, 2024
@EnricoMi EnricoMi linked a pull request Sep 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make ArrayData.align_buffers align child data buffers recursively EnricoMi/arrow-rs
1 participant
@EnricoMi