Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reqwests error display #6377

Open
crepererum opened this issue Sep 10, 2024 · 2 comments
Open

Improve reqwests error display #6377

crepererum opened this issue Sep 10, 2024 · 2 comments
Assignees
@itsjunetime
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers object-store Object Store Interface

Comments

@crepererum
Copy link
Contributor

Originally reported in #5882 (comment) :

For #5882 we only report Generic S3 error: error decoding response body. We should try to improve the error message. It seems that the Display impl. is not super helpful and we might wanna use Debug instead, see seanmonstar/reqwest#2373
@crepererum crepererum mentioned this issue Sep 10, 2024
Open
@crepererum crepererum added object-store Object Store Interface enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers labels Sep 10, 2024
@tustvold
Copy link
Contributor

tustvold commented Sep 10, 2024 •
edited
Loading

One thing to be aware of is exposing sensitive headers, or URL path segments.

We could also provide information on common causes of this error - e.g. network/runtime instability

@crepererum crepererum self-assigned this Sep 10, 2024
@itsjunetime
Copy link

take

@crepererum crepererum removed their assignment Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsjunetime itsjunetime

Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crepererum @tustvold @itsjunetime