Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ParquetObjectReader::with_runtime #6248

Open
tustvold opened this issue Aug 14, 2024 · 0 comments · May be fixed by #6249
Open

Add ParquetObjectReader::with_runtime #6248

tustvold opened this issue Aug 14, 2024 · 0 comments · May be fixed by #6249
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Tokio is a cooperative threadpool and has strong assumptions that tasks yield frequently. Running CPU-bound work on the same threadpool results in poor throughput and can lead to connections getting dropped.

Describe the solution you'd like

We should add a with_runtime option to ParquetObjectReader that takes a tokio handle and spawns all work to the provided runtime. This encourages decoupling CPU-bound query execution / parquet decoding, from cooperatively scheduled IO.

Describe alternatives you've considered

I'm aware of a number of codebases, such as InfluxDB IOx, that implement this spawning logic at the ObjectStore boundary instead.

Additional context

#4040 attempted to add something similar to object_store, but concluded this really belongs in the integrations

#5882 may be related to this

@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog help wanted labels Aug 14, 2024
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 14, 2024
@tustvold tustvold linked a pull request Aug 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant