Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement full validation for UnionArrays construction from ArrayData #1486

Closed
alamb opened this issue Mar 24, 2022 · 1 comment
Closed

Implement full validation for UnionArrays construction from ArrayData #1486

alamb opened this issue Mar 24, 2022 · 1 comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog security

Comments

@alamb
Copy link
Contributor

alamb commented Mar 24, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
It is possible to construct invalid UnionArrays when building them using the ArrayData API

Describe the solution you'd like
Validate all the data is correct for union arrays

Additional context
This is a left over from #921 when was implemented concurrently with proper UnionArray support
@alamb alamb added arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog security labels Mar 24, 2022
@alamb alamb self-assigned this Mar 24, 2022
@alamb alamb mentioned this issue Mar 24, 2022
Closed
@tustvold tustvold assigned tustvold and unassigned alamb Feb 27, 2023
@tustvold tustvold removed their assignment Apr 26, 2024
@alamb
Copy link
Contributor Author

alamb commented Aug 5, 2024

I think this was completed in #1799 so closing this one

@alamb alamb closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Full UnionArray validation alamb/arrow-rs
2 participants
@alamb @tustvold