Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchanged golden images shouldn't be updated #22

Open
laurentgoudet opened this issue Jul 15, 2019 · 0 comments · May be fixed by #23
Open

Unchanged golden images shouldn't be updated #22

laurentgoudet opened this issue Jul 15, 2019 · 0 comments · May be fixed by #23

Comments

@laurentgoudet
Copy link

Currently all the golden images are always updated when running UPDATE_GOLDENS=1, independently of if they have changed or not. This make code reviewing for visual changes hard when the code base contains hundreds of golden screenshots.

Instead, only changed images should be updated when running UPDATE_GOLDENS=1, which would allow to highlight the specific changes a code change is causing.
@laurentgoudet laurentgoudet linked a pull request Jul 15, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't update unchanged golden images
1 participant
@laurentgoudet