Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Long-term) integration with Flow.jl? #18

Open
TotalVerb opened this issue Aug 3, 2016 · 1 comment
Open

(Long-term) integration with Flow.jl? #18

TotalVerb opened this issue Aug 3, 2016 · 1 comment

Comments

@TotalVerb
Copy link

TotalVerb commented Aug 3, 2016

I had a thought. Mike Innes's Flow.jl is looking promising: https://github.com/MikeInnes/Flow.jl. The package seems general enough to deal with any kind of Julia code, which is far more powerful than alternatives like TensorFlow.

Something that sort of bugs me when using ParserCombinator as a CFG-parser is the syntax. I sort of dislike writing, and even more dislike reading,

x = Delayed()
y = Star(x)
x.matcher = Seq(e"(", y, e")")

or similar. It would be cool if that could be written

matcher(@flow function()
    x = Seq(e"(", Star(x), e"))
end)

letting Flow.jl figure out what the graph looks like. What are your thoughts? I'd be happy to work on a prototype when/if I get the time.

@andrewcooke
Copy link
Owner

sure, if you can get it to work without changing things too much (don't want to break what people already have).

although your example isn't exactly fair. you should be comparing

x = Delayed()
x.matcher = Seq(e"(", Star(x), e")")

and

matcher(@flow function()
    x = Seq(e"(", Star(x), e")")
end)

(if there was a reason for the separate Star(x) then it looks like a bug)

(sorry for not replying sooner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants