Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit visibility changes and package locations of classes in #830 #832

Open
popematt opened this issue May 6, 2024 · 0 comments
Open

Comments

@popematt
Copy link
Contributor

popematt commented May 6, 2024

Let's open an issue with a list of the classes we had to make public in this PR so we don't forget to go back and revisit them.

Originally posted by @tgregg in #830 (review)

The classes are:

  • com.amazon.ion.impl.LocalSymbolTable
  • com.amazon.ion.impl.bin.Block
  • com.amazon.ion.impl.bin.BlockAllocator
  • com.amazon.ion.impl.bin.BlockAllocatorProvider
  • com.amazon.ion.impl.bin.BlockAllocatorProviders

As part of revisiting the visibility of these classes, we also need to consider to package location of:

  • com.amazon.ion.impl.bin.IonManagedWriter_1_1
  • com.amazon.ion.impl.bin.ManagedWriterOptions_1_1
  • com.amazon.ion.impl.bin.DelimitedContainerStrategy
  • com.amazon.ion.impl.bin.SymbolInliningStrategy
  • com.amazon.ion.impl.BlockBufferingOutputStreamFastAppendable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant