Heed RAILS_LOG_LEVEL in production config. #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added to Rails's template for production.rb in https://github.com/rails/rails/blob/3b83758/railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt#L73 We want to be able to control the log level this way so that: - we don't have to rebuild an app just to change its log level - we can enable debug logging if we need it to investigate a problem that's hard to reproduce - we can tune the log levels so as not to waste resources logging things that we don't care about the rest of the time - if a change to an app introduces a problem with logspew, we can just dial down the log level while someone tracks down the underlying issue This is a bulk change; all 43 PRs are identical except for apps which had their loglevel set to `debug`, which we're resetting to `info` as the default. To approve, use https://github.com/alphagov/bulk-merger (`./review 'Heed RAILS_LOG_LEVEL in production config.`)
theseanything
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to Rails's template for production.rb in https://github.com/rails/rails/blob/3b83758/railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt#L73
We want to be able to control the log level this way so that:
This is a bulk change; all 43 PRs are identical except for apps which had their loglevel set to
debug, which we're resetting toinfoas the default.To approve, use https://github.com/alphagov/bulk-merger:
./review 'Heed RAILS_LOG_LEVEL in production config.'