Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receive function to BasStrategy #527

Open
codenamejason opened this issue Mar 25, 2024 · 0 comments
Open

Add receive function to BasStrategy #527

codenamejason opened this issue Mar 25, 2024 · 0 comments

Comments

@codenamejason
Copy link
Contributor

codenamejason commented Mar 25, 2024

Problem

"Hi! We're having some issues with using ETH as a token when creating and funding pools (we're using this address as specified in the Allo code: 0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE.
The transaction just fails without any error message. Do you have a working example we can look at for reference?
Update:
It looks like the contract requires: receive() external payable {}
I can't find this line in the BaseStrategy. Does this mean every strategy contract must implement this? "

  • From this conversation, it looks like the solution would be to add the needed function to the Base Strategy.

Apetite

Small Batch:
Add a receive() external payable {} to the BaseStrategy.sol contract. This will allow for receiving native ETH without having to implement in each strategy.

Solution

Add receive() external payable {} to BaseStrategy.sol

References

https://discord.com/channels/562828676480237578/1047159914956591114

Rabbit Holes

N/A

Planning Docs

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant