Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming permissions logs - handle data in invalid format #156

Open
MarcinFalkowski opened this issue Aug 25, 2020 · 0 comments
Open

Incoming permissions logs - handle data in invalid format #156

MarcinFalkowski opened this issue Aug 25, 2020 · 0 comments

Comments

@MarcinFalkowski
Copy link
Contributor

MarcinFalkowski commented Aug 25, 2020 •
edited
Loading

Currently we produce incoming permissions logs as a JSON, which is prepared in a non-reliable way. If particular characters (for example ") will be present in x-service-name header, the result JSON will be invalid.

To consider:

  1. Fetch serviceName from client certificate SAN URI, instead of a header.
  2. Change log format to something simpler than JSON, for example "every field in a new line"
  3. Sanitize JSON strings

More information: #152 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcinFalkowski