[FEATURE] - Replace 'hardcoded' icons with product icons

[DeltaRazero]

The icons currently used in the extension (activity bar icon and the gutter icon) are currently not themable by product icon themes. If these could be changed to use the product icon API then product icon themes can override them if desirable (i.e. to make them match the theme).

See aeschli's comment here microsoft/vscode#211811 (comment)

I can provide a pull request for providing a script for generating a product icon font, adding the contribution entries for the icons and change the activity bar icon to use the product icon API, however I cannot access the vscode-bookmarks-core repository to submit a pull-request so the gutter icon, so in that case you'll have to do that.

Awaiting your reply.

[alefragnani]

Hi @DeltaRazero ,

I thought about embracing Product Icon in the past, right after the API was released, but the problem (or limitation) is that it lacks support for workbench.colorCustomizations. So, the gutter icons wouldn't be as customizable as I want it to be. The Activity Bar icon, on the other hand, could become a product icon, for sure.

No need to worry about a PR. I have played with the sample available in vscode-extensions-sample repo in the past, and I have memories it was fairly easy to use it. It shouldn't have changed that much since then.

Thanks for your suggestion.

[DeltaRazero]

Thank you for reply.

Too bad to hear that the product icon API doesn't play well with the color customization aspect needed for the bookmarks extension, hopefully it's something that could be changed in the future.

However, even if only the activity bar icon can be a product icon, it's still a very welcoming change. I'm in the middle of making a file icon theme and product icon theme, and I'd like to support the most popular extensions or those I use personally so they fit right into the theme.

If no further PR or actions on my side are needed, then I'll leave the issue thread as is.

Thanks!