Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error after calling setLogger #46

Open
jrm0695 opened this issue Nov 14, 2021 · 1 comment
Open

Fatal error after calling setLogger #46

jrm0695 opened this issue Nov 14, 2021 · 1 comment

Comments

@jrm0695
Copy link

jrm0695 commented Nov 14, 2021

A new bug appeared with the recent update of psr/log v3. The ProcessRunnerInterface from psr/log version 3 provides a setLogger function that returns a void. PHP 8.0.12 now enforce that you declare the right return type when implementing interfaces.

As it currently return a ProcessRunner, I end up with this error when using it :
Declaration of Alchemy\BinaryDriver\ProcessRunner::setLogger(Psr\Log\LoggerInterface $logger) must be compatible with Psr\Log\LoggerAwareInterface::setLogger(Psr\Log\LoggerInterface $logger): void

Either return a void to comply to the interface, either get back to psr/log version 1 that doesn't provide any return type

@BilboTav
Copy link

I have similar issue, I would like to use this package with psr/log: ^3.0 . Would that be possible to upgrade?
Version 5.2.0 requires psr/log: ^1.0.
Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants