Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved configs not the same as input configs #32

Open
jack89roberts opened this issue Jun 19, 2024 · 0 comments
Open

Saved configs not the same as input configs #32

jack89roberts opened this issue Jun 19, 2024 · 0 comments

Comments

@jack89roberts
Copy link
Contributor

In the configs saved with the models we expand out everything (so e.g. the data config name is replaced with the actual contents of the data config). Either:

  • Make it so the experiment config class can create a config from either format
  • Make the saved format the same as the input format

And:

  • Change the eval scripts (e.g. all_eval.py) to use the experiment config class rather than using the output configs as a dictionary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant