setting eval breaks everyone's client

[michaelficarra]

window.eval = eval = function(){} makes everyones client stop evaluating until they refresh. I don't even want to know what happens when you set it to a non-function.

[airportyh]

I had a try at this, but ultimately failed to find a way that works for IE. I tried sandbox = {eval: window.eval} or similar for IE, but for some reason, when IE is doing an indirect eval, it swallows the exceptions and either shows them in a popup dialog, or in the developer tools console only. If anyone has a better idea please let me know.

[michaelficarra]

Before running an eval, you can save a reference to the native function and set it again after running eval. Maybe not the coolest fix, but it will definitely work.

[airportyh]

Fixed in ac75e96

[airportyh]

Oops! Spoke too soon. That broke exceptions on IE too. Reverted. Michael: your solution would give the wrong value for 'eval' when referenced - it would always return the actual eval function as supposed to the assigned value.

[michaelficarra]

Are you saying you want to keep proper semantics when people assign to window.eval, but without it breaking the evaling in others' browsers? Then instead of referencing window.eval when you call it, you should be caching a reference to it in a local variable and calling that function instead. Does that fix work for you?

[airportyh]

That's the thing that doesn't work. When I do that, IE will have the weird behavior wrt exceptions that I mentioned.