Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icevision no longer works with the latest sahi release #1146

Open
rafaelvp-db opened this issue Oct 29, 2022 · 5 comments
Open

Icevision no longer works with the latest sahi release #1146

rafaelvp-db opened this issue Oct 29, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@rafaelvp-db
Copy link

🐛 Bug

Describe the bug

Icevision stopped working with the latest sahi release (0.11.0).

When trying to do: from icevision.all import *

I get: ModuleNotFoundError: No module named 'sahi.model'

Looking at the code, I see the following:

sahi.model import DetectionModel

However, in the latest sahi release, the module structure contains a models subfolder, not model. For instance, in their predict.py script, there is the following:

from sahi.models.base import DetectionModel

One can look at their new folder/package structure here.

Two possible solutions:

  • Change icevision code to reference sahi.models instead of sahi.model, or
  • Pin sahi version to < 0.11.0

To Reproduce
Steps to reproduce the behavior:

  1. Install icevision
  2. Try to run from icevision.all import *

Expected behavior

Icevision modules are imported successfully

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • Python: 3.9

Additional context
Add any other context about the problem here.

@rafaelvp-db rafaelvp-db added the bug Something isn't working label Oct 29, 2022
@rafaelvp-db
Copy link
Author

btw, I'm willing to work on a fix for this

@rbavery
Copy link

rbavery commented Nov 1, 2022

@rafaelvp-db downgrading sahi to 0.10.8 solved the issue for me

@rbavery
Copy link

rbavery commented Nov 1, 2022

I think this requirement needs to be more restrictive so that only up to version 0.10.8 is installed: https://github.com/airctic/icevision/blob/master/setup.cfg#L37

@rbavery
Copy link

rbavery commented Nov 1, 2022

nevermind, there's already a PR up for this: https://github.com/airctic/icevision/pull/1147/files

@fcakyon
Copy link
Contributor

fcakyon commented Nov 13, 2022

I have also opened a PR adding support to latest sahi version: #1156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants