Tracker for Adventure 4.0 issues

[aikaterna]

Hello, please write your issues below in a comment with your traceback and the command you used to have the traceback occur or reproduction steps. Thanks for reporting.

---

Superceded comments

• give item level arg, level given seems to be ignored (may be related to dev id list?, didn't test with alternate account)
• give loot help formatting for rarity levels - can that be improved?
• Minor/Non-issue: Add item slot names to give item help
• Have a new character, get to or set character at level 11+, use heroclass command

[23:44:06] ERROR [red] UnboundLocalError
Traceback (most recent call last)
/.../python3.11/site-packages/discord/ext/commands/core.py:229 in wrapped
❱ 229 ret = await coro(*args, **kwargs)
/.../CogManager/cogs/adventure/class_abilities.py:107 in heroclass
❱ 107 currency_name=currency_name,
clz=clz.ansi(classes[clz.class_name]["name"])
UnboundLocalError: cannot access local variable 'classes' where it is not associated with a value

• Failed interactions on heroclass command do not reset heroclass cooldown

[aikaterna]

1. Missing + at critical hit?
   https://bae.lena.moe/t2ncyu7byzhb.png

This is still present but the rest above this comment should have been resolved with #425 - comment more if you find more please

[DJTOMATO]

Language typo?

Item 1 **y** Item 2

https://cdn.discordapp.com/attachments/730089724668280862/1104946010255527956/image.png

Shouldn't be "and"?

y means and in spanish, but I can triple guarantee i have uninstalled the cog and reinstalled it. None of my old translation files exists anymore.

Also the bot locale is in english for the record.

EDIT: i've checked and my custom theme DIDNT had a action_response.json file

I checked this file and there is not a string where two items were mentioned

I copied bot\cogs\CogManager\cogs\adventure\data\default\action_response.json
into my custom theme bot\cogs\Adventure\yubi\action_response.json

but the issue persists.
https://bae.lena.moe/3avddx3w6oaj.png

Seems the problem arises on the $weapon variable or the get_weapons method but I couln't figure what to do with it

[TrustyJAID]

Language typo?

Item 1 **y** Item 2

https://cdn.discordapp.com/attachments/730089724668280862/1104946010255527956/image.png

Shouldn't be "and"?

y means and in spanish, but I can triple guarantee i have uninstalled the cog and reinstalled it. None of my old translation files exists anymore.

Also the bot locale is in english for the record.

EDIT: i've checked and my custom theme DIDNT had a action_response.json file

I checked this file and there is not a string where two items were mentioned

I copied bot\cogs\CogManager\cogs\adventure\data\default\action_response.json into my custom theme bot\cogs\Adventure\yubi\action_response.json

but the issue persists. https://bae.lena.moe/3avddx3w6oaj.png

Seems the problem arises on the $weapon variable or the get_weapons method but I couln't figure what to do with it

So this happens because on the charactersheet get_weapons method calls Red's humanize_list([left, right]) when you have a left and right weapon equipped. humanize_list will implicitly check locale and apply the appropriate and or or depending on the style of list conversion passed to it.

[DJTOMATO]

Language typo?
Item 1 **y** Item 2
https://cdn.discordapp.com/attachments/730089724668280862/1104946010255527956/image.png
Shouldn't be "and"?
y means and in spanish, but I can triple guarantee i have uninstalled the cog and reinstalled it. None of my old translation files exists anymore.
Also the bot locale is in english for the record.
EDIT: i've checked and my custom theme DIDNT had a action_response.json file
I checked this file and there is not a string where two items were mentioned
I copied bot\cogs\CogManager\cogs\adventure\data\default\action_response.json into my custom theme bot\cogs\Adventure\yubi\action_response.json
but the issue persists. https://bae.lena.moe/3avddx3w6oaj.png
Seems the problem arises on the $weapon variable or the get_weapons method but I couln't figure what to do with it

So this happens because on the charactersheet get_weapons method calls Red's humanize_list([left, right]) when you have a left and right weapon equipped. humanize_list will implicitly check locale and apply the appropriate and or or depending on the style of list conversion passed to it.

But the bot locale is english in that server + discord client is also in english.
https://bae.lena.moe/77yjvw16eskc.png

changed it again to be sure and it's still showing spanish.
Now for the record, the bot locale is spanish in other servers.
Maybe it's related to the bug that don't respect global settings?
Or maybe it grabs the "global locale setting" which is spanish iirc

[DJTOMATO]

DEG item generation value is not working
!give item xxxxxxxxxx "Test item final" 1 att 2 charisma 3 int 4 dex 5 luck 7 degrade 6 level left event
https://bae.lena.moe/33lrf54xa300.png

!give item `xxxxxx "Test item2" 1 1 att 1 charisma 1 int 1 dex 1 luck event right 1 degrade 1
https://bae.lena.moe/bf6gu7pfl508.png

[japandotorg]

Mostly happens on [p]adventure, used to happen rarely back on 3.4 (only seen like 2-3 times during 3.4 days), but ever since I've updated to 3.5 this is happening pretty frequently, basically my errorlogs is now full of this error.

Traceback (most recent call last):
  File "/MELON/lib/python3.11/site-packages/discord/ext/commands/core.py", line 229, in wrapped
    ret = await coro(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/.local/share/Red-DiscordBot/data/MELON/cogs/CogManager/cogs/adventure/adventure.py", line 591, in _adventure
    async with self.get_lock(user):
  File "/usr/lib/python3.11/asyncio/locks.py", line 21, in __aexit__
    self.release()
  File "/usr/lib/python3.11/asyncio/locks.py", line 140, in release
    raise RuntimeError('Lock is not acquired.')
RuntimeError: Lock is not acquired.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/MELON/lib/python3.11/site-packages/discord/ext/commands/bot.py", line 1350, in invoke
    await ctx.command.invoke(ctx)
  File "/MELON/lib/python3.11/site-packages/discord/ext/commands/core.py", line 1023, in invoke
    await injected(*ctx.args, **ctx.kwargs)  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/MELON/lib/python3.11/site-packages/discord/ext/commands/core.py", line 238, in wrapped
    raise CommandInvokeError(exc) from exc
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: RuntimeError: Lock is not acquired.

[SenpaiCZ]

Hi, im not sure if this is an issue, but ranger bonus is higher than it should be acording to legend.

Is an error? Or some super critical bonus. It happend multiple times in one day.

[eyanez43]

Issue where all items except those equipped are deleted when rebirthing. Specifically ascended and legendary items with a valid DEG value.

Opening loot one by one because of current issue with opening multiple chests at once not setting the correct DEG value. Bottom command demonstrates the items in inventory that are not equipped.

Rebirthing and then checking inventory to demonstrate ascended items are gone and set items are still equipped.

[LokVokun]

Edit: Sorry OP was unclear. I didn't have "traceback and the command you used to have the traceback occur" so I opened #438, I apologize.

Complete these first

• I confirm that I am the owner of the bot running Adventure.
• I confirm that I have not modified the source code of Adventure.
• I'm an Adventure user but not the bot owner.
• I confirm that I have checked the issue tracker and this bug hasn't been reported already.

Command name

!a / !adventure

Expected Behavior

Normal spread of boss to general monsters.

Current Behavior

Adventure version: 4.0.0

There is about an ~80% chance that anybody who starts an adventure will generate a Dragon / Boss encounter.

Possible Solution

Steps to Reproduce

1. Start an adventure.

Context (Environment)

This has caused users to become disinterested in the adventure game because it's extremely difficult to solo Dragon / Boss monsters and needing a raid call about 4+ times an hour to get anywhere is quite extreme.

It's possible this drop rate has increased as one specific user has the ability to use hundreds of million/billion/trillion gold to NV and catapult their level to 800+ (of 1000?)

Is boss rate tied to user level(s) at all?

Yes, one user was able to NV multiple trillions of gold -- this might be an area to consider investigating of boss rates are tied to user levels / rank / etc somehow.

Detailed Description

Possible Implementation

[DJTOMATO]

Leaderboard error?

bled=False label=None emoji=<PartialEmoji animated=False name='▶️' id=None> row=None>
Jul 03 12:42:48 lena python3[1221]: Traceback (most recent call last):
Jul 03 12:42:48 lena python3[1221]:   File "/home/glas/redenv/lib/python3.11/site-packages/discord/ui/view.py", line 427, in _scheduled_task
Jul 03 12:42:48 lena python3[1221]:     await item.callback(interaction)
Jul 03 12:42:48 lena python3[1221]:   File "/mnt/hdd/data/lenabot/cogs/CogManager/cogs/adventure/menus.py", line 440, in callback
Jul 03 12:42:48 lena python3[1221]:     kwargs = await self.view._get_kwargs_from_page(page)
Jul 03 12:42:48 lena python3[1221]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 03 12:42:48 lena python3[1221]:   File "/mnt/hdd/data/lenabot/cogs/CogManager/cogs/adventure/menus.py", line 556, in _get_kwargs_from_page
Jul 03 12:42:48 lena python3[1221]:     value = await self.source.format_page(self, page)
Jul 03 12:42:48 lena python3[1221]:             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Jul 03 12:42:48 lena python3[1221]:   File "/mnt/hdd/data/lenabot/cogs/CogManager/cogs/adventure/menus.py", line 240, in format_page
Jul 03 12:42:48 lena python3[1221]:     loses_len = max(len(humanize_number(entries[0][1]["loses"])) + 3, 8)
Jul 03 12:42:48 lena python3[1221]:                                         ~~~~~~~^^^
Jul 03 12:42:48 lena python3[1221]: IndexError: list index out of range
Jul 03 14:08:13 lena python3[1221]: adding 1
Jul 03 14:08:13 lena python3[1221]: adding 1```

[aikaterna]

[p]adventure skill reset does not work as a slash command, reset is not a proper subcommand

Edit: guess it works if you put "reset" into the optional skill slot on the slash command but might be better as a real command

[aikaterna]

Bloodrage Drake needs a new image link

[Dark-lame]

Mobs images not loading despite image URL existing (not all mobs but many).

[aikaterna]

General todo: add readme link to install message

[japandotorg]

Looks like the imgur for Bloodrage Drake is dead

gobcog/adventure/data/default/monsters.json

Line 23 in f28512e

"Bloodrage Drake": {"hp": 340, "pdef": 1, "mdef": 1, "dipl": 325, "image": "https://i.imgur.com/dxEjIsT.jpg", "boss": true, "miniboss": {}, "color":""},

[Skyridr]

• Choosing a hero class and not having enough credits will not remove/disable the buttons, causing interaction failed.
• I also noticed that when you have 0 credits and attempt to choose a hero, it says you have to pay 0 credits? Is that correct?

[ltzmax]

With the [p]forge command

Traceback (most recent call last):
  File "/home/max/redenv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 235, in wrapped
    ret = await coro(*args, **kwargs)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/max/redbot/cogs/CogManager/cogs/adventure/class_abilities.py", line 940, in forge
    newitem, roll = await self._to_forge(ctx, consumed, c)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/max/redbot/cogs/CogManager/cogs/adventure/class_abilities.py", line 1092, in _to_forge
    item2 = consumed[1]
            ~~~~~~~~^^^
IndexError: list index out of range

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/max/redenv/lib/python3.11/site-packages/discord/ext/commands/bot.py", line 1366, in invoke
    await ctx.command.invoke(ctx)
  File "/home/max/redenv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 1029, in invoke
    await injected(*ctx.args, **ctx.kwargs)  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/max/redenv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 244, in wrapped
    raise CommandInvokeError(exc) from exc
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: IndexError: list index out of range

[LeDeathAmongst]

Traceback (most recent call last):
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 235, in wrapped
ret = await coro(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/cogs/CogManager/cogs/adventure/dev.py", line 93, in genitems
slot = slot.lower()
^^^^^^^^^^
AttributeError: 'Slot' object has no attribute 'lower'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/bot.py", line 1366, in invoke
await ctx.command.invoke(ctx)
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 1029, in invoke
await injected(*ctx.args, **ctx.kwargs) # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 244, in wrapped
raise CommandInvokeError(exc) from exc
discord.ext.commands.errors.CommandInvokeError: Command raised an exception: AttributeError: 'Slot' object has no attribute 'lower'
also, this show if wrong slot.. maybe make show list instead if invalid slot:
Traceback (most recent call last):
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/converter.py", line 1280, in _actual_conversion
return await converter.convert(ctx, argument)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/cogs/CogManager/cogs/adventure/converters.py", line 140, in convert
return Slot.get_from_name(argument)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/cogs/CogManager/cogs/adventure/constants.py", line 62, in get_from_name
raise KeyError(
KeyError: '1 is not a valid slot, select one of Head, Neck, Chest, Gloves, Belt, Legs, Boots, Left, Right, Two Handed, Ring, and Charm'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/bot.py", line 1366, in invoke
await ctx.command.invoke(ctx)
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 1021, in invoke
await self.prepare(ctx)
File "/data/venv/lib/python3.11/site-packages/redbot/core/commands/commands.py", line 513, in prepare
await self._parse_arguments(ctx)
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 845, in _parse_arguments
transformed = await self.transform(ctx, param, attachments)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/core.py", line 715, in transform
return await run_converters(ctx, converter, argument, param) # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/converter.py", line 1400, in run_converters
return await _actual_conversion(ctx, converter, argument, param)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/data/venv/lib/python3.11/site-packages/discord/ext/commands/converter.py", line 1288, in _actual_conversion
raise ConversionError(converter, exc) from exc # type: ignore
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
discord.ext.commands.errors.ConversionError: (<class 'adventure.converters.SlotConverter'>, KeyError('1 is not a valid slot, select one of Head, Neck, Chest, Gloves, Belt, Legs, Boots, Left, Right, Two Handed, Ring, and Charm'))