Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge mishaps with timeouts and choosing same item twice #388

Open
2 of 4 tasks
Dark-lame opened this issue Jun 2, 2022 · 0 comments
Open
2 of 4 tasks

forge mishaps with timeouts and choosing same item twice #388

Dark-lame opened this issue Jun 2, 2022 · 0 comments

Comments

@Dark-lame
Copy link

Complete these first

  • I confirm that I am the owner of the bot running Adventure.
  • I confirm that I have not modified the source code of Adventure.
  • I'm an Adventure user but not the bot owner.
  • I confirm that I have checked the issue tracker and a this bug hasn't been reported already.

Command name

forge

Expected Behavior

When running through the forge process, user should choose 2 items to forge, and respond with the names in a timely manner. End result should be a forged item in the users backpack.

Current Behavior

adventure version 3.5.3
When the user puts in the same item twice, while they only have 1 copy of the item in their backpack, the forge carries on successfully.
However, when inspecting the users backpack, the forged item is nowhere to be found, resulting in an error message in our servers bot-log.

Possible Solution

Fully cancel the forging process when theres a spelling error, or disallow the use of the same item. This should also result in a complete cancellation.

Steps to Reproduce

  1. Change to tinkerer class if not already
  2. Start forge process with name in the command, !forge Item 1
  3. Choose item, Item 1
  4. Choose item, Item 2 with same words as Item 1
  5. Spelling mistake should show at this stage
  6. Choose Item 1
  7. Forge output, check backpack. Sequence results in bot error in logs.

Context (Environment)

Hasn't resulted in a crash, but very confusing for new players and new tinkerers.
image
Bot error response
image

Detailed Description

Possible Implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant