Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic SMILES #519

Open
danielhollas opened this issue Sep 26, 2023 · 5 comments
Open

Problematic SMILES #519

danielhollas opened this issue Sep 26, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@danielhollas
Copy link
Contributor

List of SMILES which currently do not work in SmilesWidget. Feel free to reopen the issue if you come up with new ones!

  1. [H][C]1C2=CC=CC3=C2C(C4=C1C=CC5=C4C6=C(C7=C([C]([H])C8=CC=CC9=CC=CC7=C98)C=C%10)C%10=CC=C6C=C5)=CC=C3
@danielhollas danielhollas added the bug Something isn't working label Sep 26, 2023
@danielhollas danielhollas self-assigned this Sep 26, 2023
@danielhollas
Copy link
Contributor Author

I briefly looked into it and this SMILES will be harder to fix, none of the various RDkit options I tried worked.

Next step is to try to tease out a concrete Error coming from RDkit. If we do not manage to figure this out, I'll open an issue on RDKit itself.

@fabioacl
Copy link
Collaborator

fabioacl commented Jun 4, 2024

I used RDKit to generate the following SMILES from a CDXML file:

Cc1cccc(C)c1-c1c2ccccc2c(C2=c3ccc4n3[Zn]35n6c(ccc6C(c6c7ccccc7c(-c7c(C)cccc7C)c7ccccc67)=c6ccc(n63)=Cc3ccc2n35)C=4)c2ccccc12

I checked whether it was a problem with the SMILES but it works using Mathematica.

image

@cpignedoli
Copy link
Member

@danielhollas this also fails in the SMILES widget, do you think it is related to the same problem you mentioned before?

@danielhollas
Copy link
Contributor Author

@cpignedoli hard to say without taking a closer look. Note that I will be away on holiday until 20th so will not have a look until then.

It would be helpful if you could provide a more concrete RDKit error. Note that when using SmilesWidget, you need to run it from within a plain notebook interface, since Appmode hides errors by default.

@cpignedoli
Copy link
Member

@danielhollas I will ask @fabioacl to document the rdkit error, will be ready for after your holidays :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants