Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AG0019 to allow for unit test projects #163

Open
dicko2 opened this issue Mar 3, 2022 · 0 comments
Open

Change AG0019 to allow for unit test projects #163

dicko2 opened this issue Mar 3, 2022 · 0 comments

Comments

@dicko2
Copy link
Contributor

dicko2 commented Mar 3, 2022

AgodaAnalyzers/src/Agoda.Analyzers/AgodaCustom/AG0019PreventUseOfInternalsVisibleToAttribute.cs

Line 41 in 67253b5

var attributeNode = (AttributeListSyntax)context.Node;

If the target project has "test" in the name then not fail.

We think this is acceptable for some test projects in some scenarios

https://dotnetthoughts.net/dotnet-minimal-api-integration-testing/

Example here, its mandatory to use with minimal API + webapplicationfactory from MVC testing library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dicko2