Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork effects return tasks. #689

Open
dlech opened this issue May 18, 2023 · 0 comments
Open

Fork effects return tasks. #689

dlech opened this issue May 18, 2023 · 0 comments

Comments

@dlech
Copy link

dlech commented May 18, 2023 •
edited
Loading 

const task = yield* takeEvery(someAction, handleSomeAction);

In this statement, task currently has type of never since fork effects like takeEvery have a return type of SagaGenerator<never, ForkEffect<never>>.

I think these should be replaced with SagaGenerator<Task, ForkEffect<never>> since all fork effects return a Task object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dlech