From 6a90fdf2f4e19bca7f6a95bcd8e8b88d79257aa1 Mon Sep 17 00:00:00 2001 From: eprogramming <00hf11@gmail.com> Date: Tue, 10 Feb 2015 20:31:55 -0300 Subject: [PATCH] fix pmd default rules --- build.gradle | 7 ++++--- src/main/java/org/jboss/aesh/mterm/action/BaseAction.java | 2 +- .../org/jboss/aesh/mterm/action/menu/MenuTitleAction.java | 3 --- src/main/java/org/jboss/aesh/mterm/util/AeshUtil.java | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/build.gradle b/build.gradle index c9de322..f366c42 100644 --- a/build.gradle +++ b/build.gradle @@ -23,9 +23,10 @@ apply plugin: 'idea' apply plugin: 'eclipse' apply plugin: 'maven' apply plugin: 'application' +apply plugin: 'pmd' group = 'org.jboss.aesh' -version = '0.57-SNAPSHOT' +version = '0.57' mainClassName = 'org.jboss.aesh.mterm.Mterm' @@ -49,7 +50,7 @@ test { dependencies { compile group: 'org.jboss.aesh', name: 'aesh', version: version - compile group: 'org.jboss.aesh', name: 'aesh-extensions', version: version + compile group: 'org.jboss.aesh', name: 'aesh-extensions', version: '0.57-SNAPSHOT' compile group: 'org.codehaus.groovy', name: 'groovy', version: '2.1.6' testCompile group: 'junit', name: 'junit', version: '4.+' testCompile group: 'org.easytesting', name: 'fest-swing', version: '1.2.1' @@ -57,4 +58,4 @@ dependencies { task wrapper(type: Wrapper) { gradleVersion = '2.2.1' -} \ No newline at end of file +} diff --git a/src/main/java/org/jboss/aesh/mterm/action/BaseAction.java b/src/main/java/org/jboss/aesh/mterm/action/BaseAction.java index 7892260..3d9a4d0 100644 --- a/src/main/java/org/jboss/aesh/mterm/action/BaseAction.java +++ b/src/main/java/org/jboss/aesh/mterm/action/BaseAction.java @@ -45,7 +45,7 @@ protected String readLine() { int lineOffset = textArea.getLineOfOffset(textArea.getCaretPosition()); int lineStart = textArea.getLineStartOffset(lineOffset); int lineEnd = textArea.getLineEndOffset(lineOffset); - return textArea.getText(lineStart, (lineEnd - lineStart)); + return textArea.getText(lineStart, lineEnd - lineStart); } catch (BadLocationException e) { e.printStackTrace(); diff --git a/src/main/java/org/jboss/aesh/mterm/action/menu/MenuTitleAction.java b/src/main/java/org/jboss/aesh/mterm/action/menu/MenuTitleAction.java index ab7b0ba..56c0df7 100644 --- a/src/main/java/org/jboss/aesh/mterm/action/menu/MenuTitleAction.java +++ b/src/main/java/org/jboss/aesh/mterm/action/menu/MenuTitleAction.java @@ -36,8 +36,5 @@ public void actionPerformed(ActionEvent e) { JOptionPane.PLAIN_MESSAGE, null, null, mtermUI.getTitle()); mtermUI.setTitle(newTitle); - - return; - } } diff --git a/src/main/java/org/jboss/aesh/mterm/util/AeshUtil.java b/src/main/java/org/jboss/aesh/mterm/util/AeshUtil.java index cc69150..fbd6d9c 100644 --- a/src/main/java/org/jboss/aesh/mterm/util/AeshUtil.java +++ b/src/main/java/org/jboss/aesh/mterm/util/AeshUtil.java @@ -105,7 +105,7 @@ public String getResult() { * @throws IOException exception */ public void run(String command) throws IOException { - getPos().write((command).getBytes()); + getPos().write(command.getBytes()); getPos().write(Config.getLineSeparator().getBytes()); getPos().flush(); pause();