"'bool' object has no attribute 'get'" error occurs in ZabbixSender.send() function

[valkyrie084]

Hello,

I found a problem and will report it.

Perhaps the conditional statement in the ZabbixSender._chunk_send() function on line 425 of pyzabbix/sender.py may be incorrect.

if response and response.get('response') != 'success':

If False is returned from ZabbixSender._get_response() function on line 422 of pyzabbix/sender.py, exception handling may not be executed.

Probably the correct one is as follows.

if not response or response.get('response') != 'success':

[adubkov]

Thanks. I have to look deeper into it, but it indeed looks like a bug, or at least something to improve.

Also not sure why logging has } character

py-zabbix/pyzabbix/sender.py

Line 426 in 8d2b855

logger.debug('Response error: %s}', response)

. I'm worry that somebody may use current log format in logstash or SIEMs already... have to be careful.

[valkyrie084]

Thank you for your prompt reply.

Please investigate that.

Also not sure why logging has } character

py-zabbix/pyzabbix/sender.py

Line 426 in 8d2b855

logger.debug('Response error: %s}', response)

. I'm worry that somebody may use current log format in logstash or SIEMs already... have to be careful.

It's true, I didn't realize there was an error there as well.