Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slides_url to Talk model #153

Open
marcoroth opened this issue Aug 20, 2024 · 2 comments · May be fixed by #162
Open

Add slides_url to Talk model #153

marcoroth opened this issue Aug 20, 2024 · 2 comments · May be fixed by #162

Comments

@marcoroth
Copy link
Contributor

I noticed that some of the talks have an URL to the slides in the description. Maybe we can add that to the Talk model and link/embed them in a nice way next to the video.

For the Ruby Unconf talks (#114) I added a slides_url field to the YAML files where I had it available.
@adrienpoly
Copy link
Owner

yes we can try to add this field. I am afraid the links might get broken at some point
On the other side I would like to avoid hosting files if possible so a link is the best solution for now

@marcoroth
Copy link
Contributor Author

marcoroth commented Aug 22, 2024 •
edited
Loading

I think we could embed it, if we would whitelist the common slide hosters, like speakerdeck.com, or just embed it if it's just a plain PDF file.

@marcoroth marcoroth linked a pull request Aug 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add slides_url to Talk model marcoroth/rubyvideo
2 participants
@marcoroth @adrienpoly