Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-alias use/import when organizing directives #137

Closed
novaugust opened this issue Mar 16, 2024 · 0 comments · Fixed by #155
Closed

de-alias use/import when organizing directives #137

novaugust opened this issue Mar 16, 2024 · 0 comments · Fixed by #155
Labels
bug Something isn't working enhancement New feature or request

Comments

@novaugust
Copy link
Contributor

the alias lifting implementation (#135 ) has shown that it wouldn't be unreasonable for styler to de-alias nodes moved above the alias they were using, fixing a longstanding user problem

Example Input

From the readme:

defmodule MyModule do
  @moduledoc "Implements MyBehaviour!"
  alias Deeply.Nested.MyBehaviour
  @behaviour MyBehaviour

end

should become

defmodule MyModule do
  @moduledoc "Implements MyBehaviour!"
  @behaviour Deeply.Nested.MyBehaviour
  alias Deeply.Nested.MyBehaviour

end
@novaugust novaugust added bug Something isn't working enhancement New feature or request labels Mar 16, 2024
novaugust added a commit that referenced this issue Apr 8, 2024
closes #137

fixes what may be styler's longest standing bug/user complaint/onboarding nightmare.
horay!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant