Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and discuss adiwg_evaluationMethod codelist #58

Open
2 tasks
hmaier-fws opened this issue Feb 2, 2024 · 1 comment
Open
2 tasks

Review and discuss adiwg_evaluationMethod codelist #58

hmaier-fws opened this issue Feb 2, 2024 · 1 comment
Labels
discussion Issue for discussion by stakeholder group

Comments

@hmaier-fws
Copy link
Contributor

This issue is a placeholder to review and discuss any outstanding issues related to the adiwg_evaluationMethod.yml codelist (see original isssue #40 and PR #53). It seems that this codelist is intended to represent the DQ_EvaluationMethod class names, however, in a more user friendly manner, intended to populate a mdEditor pick-list.

Items for review/discussion

  • DQ_IndirectEvaluation is not in codelist
  • DQ_EvaluationMethod is in the codelist, is that correct?

See:

DQ_IndirectEvaluation

The codelist does not include a DQ_IndirectEvaluation equivalent, however, it is described in the schema. See:

DQ_EvaluationMethod

The DQ_EvaluationMethod seems to be an abstract parent class that must be one of:

  • mdq:DQ_AggregationDerivation
  • mdq:DQ_FullInspection
  • mdq:DQ_SampleBasedInspection
  • mdq:DQ_IndirectEvaluation

Can DQ_EvaluationMethod stand on it's own without specifying any of the above? If not, should it be in the codelist?

@hmaier-fws hmaier-fws added the discussion Issue for discussion by stakeholder group label Feb 2, 2024
@dwalt
Copy link

dwalt commented Feb 2, 2024

Yes, EvaluationMethod is needed as a class. All the sub-classes are conceptual "type" classes. Only SampleBasedInspection contains elements: samplingScheme, lotDescription and samplingRatio. As a result, Stan denormalized these elements at the EvaluationMethod level. EvaluationMethod does not belong in the codelist, only the sub-classes. See adiwg/mdJson-schemas#226.

DataEvaluation is missing, please add. 19157:2023 has removed prefixes from class names. The current list is as follows:

  • DataEvaluation
  • AggregationDeriviation
  • FullInspection
  • SampleBasedInspection
  • IndirectEvaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issue for discussion by stakeholder group
Projects
None yet
Development

No branches or pull requests

2 participants