Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using {...} for multi-line blocks. #6

Open
adalbertobrant opened this issue Oct 3, 2021 · 1 comment
Open

Avoid using {...} for multi-line blocks. #6

adalbertobrant opened this issue Oct 3, 2021 · 1 comment
Assignees
Labels
agile bestpractice best practice to coding in ruby. bug Something isn't working enhancement New feature or request hacktoberfest2021 issues for the bigger help the Hacktoberfest 2021 ruby

Comments

@adalbertobrant
Copy link
Owner

adalbertobrant commented Oct 3, 2021

Hello My friends.

Filename: acoes.rb

This issue is a bit more complex, so if you have some expertise with Ruby Language this issue is for you.

In the code, it has been made with {....}, but my friend DeepSource a nice girl, told me that is not a best practice and suggested that I have to change the code for something like that:
image

So, as the pictures are showing we need to change and make a better practices in the code.

That is your task, to point where is the problem and make the necessary correction, test if the code is still working, and do the nice pull request.

Thanks a lot for your help, and God Bless You.

Happy Hacktoberfest 2021

@adalbertobrant adalbertobrant added bug Something isn't working enhancement New feature or request good first issue Good for newcomers hacktoberfest2021 issues for the bigger help the Hacktoberfest 2021 agile ruby bestpractice best practice to coding in ruby. labels Oct 3, 2021
@adalbertobrant adalbertobrant removed the good first issue Good for newcomers label Oct 3, 2021
@eduardopatrick
Copy link

I'll work on this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agile bestpractice best practice to coding in ruby. bug Something isn't working enhancement New feature or request hacktoberfest2021 issues for the bigger help the Hacktoberfest 2021 ruby
Projects
None yet
Development

No branches or pull requests

2 participants