Support setting parent_controller #903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
=======================================
Coverage 98.91% 98.92%
=======================================
Files 14 14
Lines 555 556 +1
=======================================
+ Hits 549 550 +1
Misses 6 6 ☔ View full report in Codecov by Sentry. |
charnellh8
approved these changes
Jun 6, 2024
jaynetics
force-pushed
the
support-setting-parent-controller
branch
from
405c7c7
to
a156fb0
Compare
|
rebased to bring up-to-date with master. @tagliala could we get this one merged? |
tagliala
reviewed
Jul 14, 2024
| force_parent_controller('ActionController::Base') | ||
|
|
||
| assert_equal ActionController::Base, InheritedResources::Base.superclass | ||
| force_parent_controller(original_parent.to_s) # restore original parent |
There was a problem hiding this comment.
shouldn't this be in something like ensure ?
jaynetics
force-pushed
the
support-setting-parent-controller
branch
from
a156fb0
to
78d7b34
Compare
jaynetics
force-pushed
the
support-setting-parent-controller
branch
from
78d7b34
to
817d23d
Compare
tagliala
reviewed
Jul 15, 2024
|
|
||
| # Inherit from a different controller. This only has an effect if changed | ||
| # before InheritedResources::Base is loaded, e.g. in a rails initializer. | ||
| mattr_accessor(:parent_controller) { '::ApplicationController' } |
There was a problem hiding this comment.
can I ask if this is the same as
?
There was a problem hiding this comment.
@tagliala i'd say its equivalent – the block is evaluated and the class variable is set immediately:
i think the devise code is just like that because when José Valim wrote these lines 13 years ago, mattr_accessor did not yet support passing a default value:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #618
for the interface, i mirrored
Devise::parent_controller=.