Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When element's nodetype is 9 return empty string instead of throwing error. #953

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

8ivek
Copy link

@8ivek 8ivek commented May 6, 2022

I was constantly getting following error:
Failed to execute 'getComputedStyle' on 'Window': parameter is not of type 'Element'

and I solved it using this solution.

@aFarkas
Copy link
Owner

aFarkas commented May 6, 2022

Thank you very much. Could you give me a test case where this problem is happening?

@8ivek
Copy link
Author

8ivek commented May 6, 2022

I am getting this error in one of our private project where we are including a lot of js files, I haven't been able to isolate whats the exact case when this error is happening but I doubt this is happening when we use lazysizes.js with jquery-migrate.min.js. If i'm able to isolate i'll post it here.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants